osd: fix dpdk memzon mz_name setting issue #19809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tchaikov thanks for your correction. It passed my compile and test, but after saw your comment I used gdb to check, the mz_name format is not right, so correct it. |
tchaikov
reviewed
Jan 6, 2018
src/msg/async/dpdk/DPDK.cc
Outdated
| @@ -498,7 +498,7 @@ bool DPDKQueuePair::init_rx_mbuf_pool() | |||
|
|
|||
| int bufs_count = cct->_conf->ms_dpdk_rx_buffer_count_per_core - mbufs_per_queue_rx; | |||
| int mz_flags = RTE_MEMZONE_1GB|RTE_MEMZONE_SIZE_HINT_ONLY; | |||
| char mz_name[RTE_MEMZONE_NAMESIZE]; | |||
There was a problem hiding this comment.
could you move the definition of mz_name close to where it is used?
liu-chunmei
force-pushed
the
fix_dpdk_mzname_setting_issue
branch
from
b291575
to
8357661
Compare
Signed-off-by: chunmei Liu <chunmei.liu@intel.com>
liu-chunmei
force-pushed
the
fix_dpdk_mzname_setting_issue
branch
from
8357661
to
623c6bd
Compare
|
@tchaikov updated patch. please review. |
tchaikov
approved these changes
Jan 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: chunmei Liu chunmei.liu@intel.com