common/time: add time.h for Alpine build #19863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dx9 mind taking a look? |
|
LGTM Build fails with gcc version 6.4.0 on Alpine 3.7 without this change. POSIX header <sys/time.h> shall define timeval - http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/sys_time.h.html |
|
@dx9 thanks for testing this fix! @renhwztetecs needs to rebase against master. |
We create the Alpine apk package to view "https://github.com/ceph/ceph/blob/master/README.alpine.md", at compile time found the following error: "/src/common/ceph_time.h:209:4: error: invalid use of incomplete type 'struct ceph :: time_detail :: timeval'. Signed-off-by: huanwen ren <ren.huanwen@zte.com.cn>
renhwztetecs
force-pushed
the
renhw-wip-common-time
branch
from
4a03560
to
771ecd5
Compare
|
@tchaikov thank you |
tchaikov
approved these changes
Jan 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following error, compiled in alpine:
"/src/common/ceph_time.h:209:4: error: invalid use of incomplete type 'struct ceph :: time_detail :: timeval'.
Updating the linker or the compiler may solve it, but there are some restrictions in alpine.
Signed-off-by: huanwen ren ren.huanwen@zte.com.cn