build: do_cmake: allow ARGS to be overridden #19876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
approved these changes
Jan 10, 2018
tchaikov
reviewed
Jan 10, 2018
do_cmake.sh
Outdated
| @@ -5,7 +5,7 @@ if test -e build; then | |||
| exit 1 | |||
| fi | |||
|
|
|||
| ARGS="" | |||
| ARGS="${ARGS:-}" | |||
There was a problem hiding this comment.
how about just removing this line? but i am fine if we want to make the default value more explicit.
There was a problem hiding this comment.
I'll remove the line, that is cleaner;
so that one can do stuff like ARGS="-DCMAKE_C_COMPILER=gcc-7 -D.." ./do_cmake.sh Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
theanalyst
force-pushed
the
build/do-cmake-args
branch
from
edd25f5
to
46107b9
Compare
Add an example on how to use ARGS to override cmake builds Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
theanalyst
force-pushed
the
build/do-cmake-args
branch
from
46107b9
to
d617538
Compare
|
@tchaikov updated and added a small note |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that one can do stuff like
ARGS="-DCMAKE_C_COMPILER=gcc-7 -D.." ./do_cmake.sh
Signed-off-by: Abhishek Lekshmanan abhishek@suse.com