rgw: fix handling of ENOENT in RGWRadosGetOmapKeysCR #19878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when this operates on a nonexistent object, the osd will reject the request with ENOENT before trying to process the subops. so Objecter will get back a subop return code of 0, try to decode an empty bufferlist into the result and map that subop return code to EIO by using the AioCompletion's return code, we get the correct result of ENOENT instead Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
adamemerson
approved these changes
Jan 9, 2018
| { | ||
| int r = cn->completion()->get_return_value(); | ||
|
|
||
| set_status() << "request complete; ret=" << r; |
There was a problem hiding this comment.
LGTM, I have searched aio_operate in RGW code to check whether there is similar problem. It seems that all async rados CR(RGWRadosSetOmapKeysCR, RGWRadosRemoveOmapKeysCR, RGWRadosRemoveCR, RGWRadosBILogTrimCR) already use cn->completion()->get_return_value().
maybe we should create a base class, avoid those duplicated code?
There was a problem hiding this comment.
maybe we should create a base class, avoid those duplicated code?
that sounds reasonable, yeah. it would help distinguish the ops that use aio_operate vs async_rados
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when this operates on a nonexistent object, the osd will reject the request with ENOENT before trying to process the subops. so Objecter will get back a subop return code of 0, try to decode an empty bufferlist into the result and map that subop return code to EIO. by using the AioCompletion's return code, we get the correct result of ENOENT instead
separately, it now calls omap_get_keys2() instead of omap_get_vals2(), and uses set<string> instead of map<string, bufferlist> accordingly