config: lower default omap entries recovered at once #19910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For large omap DBs, reading 64k leads to heartbeat timeouts. There are numerous callchains leading to this recovery step, many of which do not have heartbeat handles, so for an easily backported version just change the default number of entries read. DBs approaching 100GB may require an even lower setting, but this should be good enough for most clusters, without sacrificing recovery speed. Fixes: http://tracker.ceph.com/issues/21897 Signed-off-by: Josh Durgin <jdurgin@redhat.com>
liewegas
approved these changes
Jan 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For large omap DBs, reading 64k leads to heartbeat timeouts. There
are numerous callchains leading to this recovery step, many of which
do not have heartbeat handles, so for an easily backported version
just change the default number of entries read. DBs approaching 100GB
may require an even lower setting, but this should be good enough for
most clusters, without sacrificing recovery speed.
Fixes: http://tracker.ceph.com/issues/21897
Signed-off-by: Josh Durgin jdurgin@redhat.com