osd: Sign in early SIGHUP signal #19958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renhwztetecs
force-pushed
the
renhw-wip-osd-sighup
branch
2 times, most recently
from
00db0d9
to
233f01b
Compare
|
makes sense to me. might need to update the commit message to note down the rationale of the change, also the point of moving the calls to register the sighandler is to register the SIGHUP before the first blocking call, which is, |
renhwztetecs
force-pushed
the
renhw-wip-osd-sighup
branch
from
233f01b
to
d4421f7
Compare
|
@tchaikov |
renhwztetecs
force-pushed
the
renhw-wip-osd-sighup
branch
7 times, most recently
from
032dde2
to
e0767f0
Compare
In the process of starting the osd process,if system just call the
logratote("killall -q -1 ceph-mon ceph-mgr ceph-mds ceph-osd ceph-fuse radosgw...")
it will cause osd'init failed to start,
in addition, osd init slower than before, will increase the chances of the error.
Other modules(mon\mds\mgr...) also have type problems, but the most serious osd problem,
I can then make other modules similar changes.
Fixes: http://tracker.ceph.com/issues/22746
Signed-off-by: huanwen ren <ren.huanwen@zte.com.cn>
renhwztetecs
force-pushed
the
renhw-wip-osd-sighup
branch
from
e0767f0
to
da3ba00
Compare
jcsp
approved these changes
Jan 25, 2018
|
Yep, seems sensible that these calls should come right after common_init_finish |
tchaikov
approved these changes
Feb 2, 2018
|
@renhwztetecs as we discussed, this change also applies to other daemons of ceph whose log messages are logroated. do you want to do it in this PR, or leave it for future? i am good either way =) |
|
@tchaikov |
renhwztetecs
force-pushed
the
renhw-wip-osd-sighup
branch
from
1074e65
to
61ad065
Compare
tchaikov
approved these changes
Feb 5, 2018
Contains the following process: ceph-mon ceph-mgr ceph-mds ceph-fuse radosgw. Signed-off-by: huanwen ren <ren.huanwen@zte.com.cn>
renhwztetecs
force-pushed
the
renhw-wip-osd-sighup
branch
from
61ad065
to
7060a6a
Compare
|
added it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the process of starting the osd process,if system just call the
logratote("killall -q -1 ceph-mon ceph-mgr ceph-mds ceph-osd ceph-fuse radosgw...")
it will cause osd'init failed to start,
in addition, osd init slower than before, will increase the chances of the error.
Other modules(mon\mds\mgr...) also have type problems, but the most serious osd problem,
I can then make other modules similar changes.
Signed-off-by: huanwen ren ren.huanwen@zte.com.cn