Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa/tasks/ceph: ignore failure when chown ceph:ceph #19987

Merged
merged 1 commit into from Nov 16, 2018

Conversation

tchaikov
Copy link
Contributor

we didn't have ceph:ceph user back in hammer. so ignore this error.
ceph-common will create this user in newer version. and ceph task will
take care of this, when upgrading to a newer version.

Fixes: http://tracker.ceph.com/issues/22597
Signed-off-by: Kefu Chai kchai@redhat.com

@tchaikov
Copy link
Contributor Author

tchaikov commented Jan 17, 2018

@tchaikov tchaikov force-pushed the wip-22597 branch 2 times, most recently from 98e94e5 to 1dcbe0e Compare January 17, 2018 15:06
Copy link
Member

@jdurgin jdurgin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like a reasonable workaround, I don't think chown would fail for any other reason, and if it did we'd find out quickly when the osd runs

we didn't have ceph:ceph user back in hammer. so ignore this error.
ceph-common will create this user in newer version. and `ceph` task will
take care of this, when upgrading to a newer version.

Fixes: http://tracker.ceph.com/issues/22597
Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov
Copy link
Contributor Author

changelog

  • guard another "chown ceph:ceph" with try-except.

@tchaikov
Copy link
Contributor Author

the test failed

2018-01-17T16:50:11.224 INFO:teuthology.orchestra.run.smithi200:Running: 'sudo adjust-ulimits ceph-coverage /home/ubuntu/cephtest/archive/coverage timeout 120
 ceph --cluster ceph tell osd.0 flush_pg_stats'
2018-01-17T16:50:11.298 INFO:teuthology.orchestra.run.smithi200:Running: 'sudo adjust-ulimits ceph-coverage /home/ubuntu/cephtest/archive/coverage timeout 120
 ceph --cluster ceph tell osd.1 flush_pg_stats'
2018-01-17T16:50:11.366 INFO:teuthology.orchestra.run.smithi200:Running: 'sudo adjust-ulimits ceph-coverage /home/ubuntu/cephtest/archive/coverage timeout 120
 ceph --cluster ceph tell osd.2 flush_pg_stats'
2018-01-17T16:50:11.443 INFO:teuthology.orchestra.run.smithi200:Running: 'sudo adjust-ulimits ceph-coverage /home/ubuntu/cephtest/archive/coverage timeout 120
 ceph --cluster ceph tell osd.3 flush_pg_stats'
2018-01-17T16:50:11.526 INFO:teuthology.orchestra.run.smithi200:Running: 'sudo adjust-ulimits ceph-coverage /home/ubuntu/cephtest/archive/coverage timeout 120
 ceph --cluster ceph osd last-stat-seq osd.0'

seems we are sending some command hammer cluster does not understand. and all pgs stuck in "creating" state. i will try to debug the cluster when it is still running.

@tchaikov tchaikov self-assigned this Jan 19, 2018
@yuriw
Copy link
Contributor

yuriw commented Jul 20, 2018

@tchaikov having issues to merge

--- pr 19987 --- pulling https://github.com/tchaikov/ceph.git branch wip-22597
remote: Counting objects: 5, done.
remote: Total 5 (delta 4), reused 4 (delta 4), pack-reused 1
Unpacking objects: 100% (5/5), done.
From https://github.com/tchaikov/ceph

  • branch wip-22597 -> FETCH_HEAD
    CONFLICT (file/directory): There is a directory with name src/dmclock in 9f52380. Adding src/dmclock as src/dmclock~HEAD
    Auto-merging qa/tasks/ceph.py
    Adding qa/suites/rbd/mirror/cluster
    Adding qa/suites/rbd/mirror/base
    Automatic merge failed; fix conflicts and then commit the result.
    Traceback (most recent call last):
    File "/home/yuriw/wip_master/src/script/build-integration-branch", line 62, in
    assert not r
    AssertionError

@stale
Copy link

stale bot commented Oct 17, 2018

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you are a maintainer or core committer, please follow-up on this issue to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@stale stale bot added the stale label Oct 17, 2018
@tchaikov
Copy link
Contributor Author

retest this please.

@yuriw
Copy link
Contributor

yuriw commented Nov 9, 2018

@tchaikov has conflicts

--- pr 19987 --- pulling https://github.com/tchaikov/ceph.git branch wip-22597
remote: Enumerating objects: 4, done.
remote: Counting objects: 100% (4/4), done.
remote: Total 5 (delta 4), reused 4 (delta 4), pack-reused 1
Unpacking objects: 100% (5/5), done.
From https://github.com/tchaikov/ceph

  • branch wip-22597 -> FETCH_HEAD
    CONFLICT (file/directory): There is a directory with name src/dmclock in 9f52380. Adding src/dmclock as src/dmclock~HEAD
    Auto-merging qa/tasks/ceph.py
    Adding qa/suites/rbd/mirror/cluster
    Adding qa/suites/rbd/mirror/base
    Adding qa/suites/multimds/thrash/mount
    Adding qa/suites/multimds/basic/mount
    warning: inexact rename detection was skipped due to too many files.
    warning: you may want to set your merge.renamelimit variable to at least 2422 and retry the command.
    Automatic merge failed; fix conflicts and then commit the result.
    Traceback (most recent call last):
    File "/home/yuriw/wip_master/src/script/build-integration-branch", line 62, in
    assert not r

@liewegas liewegas merged commit 9f52380 into ceph:master Nov 16, 2018
liewegas added a commit that referenced this pull request Nov 16, 2018
* refs/pull/19987/head:
	qa/tasks/ceph: ignore failure when chown ceph:ceph

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
@tchaikov tchaikov deleted the wip-22597 branch November 16, 2018 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants