osd: only exit if *latest* map(s) say we are destroyed #19988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible our current map is older, we were destroyed then, but in newer maps our osd was recreated. This happens when the oldest map after a recreated osd happens to land on an epoch where the osd was marked destroyed. Fix by only exiting if one of the newest maps says we are (still) destroyed. Fixes: http://tracker.ceph.com/issues/22673 Signed-off-by: Sage Weil <sage@redhat.com>
tchaikov
approved these changes
Jan 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible our current map is older, we were destroyed then, but in
newer maps our osd was recreated. This happens when the oldest map after
a recreated osd happens to land on an epoch where the osd was marked
destroyed.
Fix by only exiting if one of the newest maps says we are (still)
destroyed.
Fixes: http://tracker.ceph.com/issues/22673
Signed-off-by: Sage Weil sage@redhat.com