Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rbd: add deep cp CLI method #19996

Merged
merged 1 commit into from Jan 26, 2018
Merged

rbd: add deep cp CLI method #19996

merged 1 commit into from Jan 26, 2018

Conversation

Songweibin
Copy link
Contributor

Signed-off-by: songweibin song.weibin@zte.com.cn

dillaman
dillaman approved these changes Jan 18, 2018
View reviewed changes
Copy link

@dillaman dillaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dillaman
Copy link

This will need to be rebased once PR #19821 is merged

@dillaman
Copy link

retest this please

@Songweibin Songweibin force-pushed the wip-rbd-deep-cp branch 3 times, most recently from 62159ea to e80ef4f Compare January 20, 2018 07:57
@Songweibin
Copy link
Contributor Author

@dillaman Rebased, thank you.

@dillaman
Copy link

The cli_generic.sh test fails:

2018-01-23T03:42:24.515 INFO:tasks.workunit.client.0.smithi115.stderr:+ rbd deep copy testimg1 testimg4
2018-01-23T03:42:24.550 INFO:tasks.workunit.client.0.smithi115.stderr:
Image deep copy: 0% complete...failed.2018-01-23 03:42:24.752 7f80fb8f0780 -1 librbd: rbd image testimg4 already exists
2018-01-23T03:42:24.550 INFO:tasks.workunit.client.0.smithi115.stderr:
2018-01-23T03:42:24.550 INFO:tasks.workunit.client.0.smithi115.stderr:rbd: deep copy failed: (17) File exists
2018-01-23T03:42:24.551 INFO:tasks.workunit.client.0.smithi115.stderr:2018-01-23 03:42:24.752 7f80fb8f0780 -1 librbd::api::Image: deep_copy: header creation failed

http://qa-proxy.ceph.com/teuthology/jdillaman-2018-01-22_15:45:01-rbd-wip-jd-testing-distro-basic-smithi/2101139/teuthology.log

@Songweibin
Copy link
Contributor Author

@dillaman Add testimg4 testimg5 testimg6 in IMGS. Thank you.

-IMGS="testimg1 testimg2 testimg3 testimg-diff1 testimg-diff2 testimg-diff3 foo foo2 bar bar2 test1 test2 test3 clone2"
+IMGS="testimg1 testimg2 testimg3 testimg4 testimg5 testimg6 testimg-diff1 testimg-diff2 testimg-diff3 foo foo2 bar bar2 test1 test2 test3 clone2"

@Songweibin
rbd: add deep cp CLI method
0551029 
Signed-off-by: songweibin <song.weibin@zte.com.cn>
@dillaman dillaman merged commit 6253490 into ceph:master Jan 26, 2018
@Songweibin Songweibin deleted the wip-rbd-deep-cp branch January 26, 2018 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dillaman dillaman dillaman approved these changes

Assignees
No one assigned
Labels
feature needs-qa rbd
Projects
None yet
Milestone
No milestone
3 participants
@Songweibin @dillaman @xiexingguo