Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mon: do not use per_pool_sum_delta to show recovery summary #20009

Merged
merged 2 commits into from Jan 26, 2018
Merged

mon: do not use per_pool_sum_delta to show recovery summary #20009

merged 2 commits into from Jan 26, 2018

Conversation

liuchang0812
Copy link
Contributor

@liuchang0812 liuchang0812 commented Jan 18, 2018 •
edited

Fixes: http://tracker.ceph.com/issues/22727

before:

pool fs_data id 16
  -71/12 objects degraded (-591.667%)
  -874/12 objects misplaced (-7283.333%)
  recovery io 28040 kB/s, 75 objects/s
  client io 85 B/s wr, 0 op/s rd, 0 op/s wr

after

2018-01-18 22:48:04.595067 mon.a [WRN] Health check update: Degraded data redundancy: 485/1455 objects degraded (33.333%), 16 pgs degraded (PG_DEGRADED)

# ./bin/ceph osd pool stats 
*** DEVELOPER MODE: setting PATH, PYTHONPATH and LD_LIBRARY_PATH ***
2018-01-18 22:48:35.354 7fbc0d931700 -1 WARNING: all dangerous and experimental features are enabled.
2018-01-18 22:48:35.422 7fbc0d931700 -1 WARNING: all dangerous and experimental features are enabled.
pool cephfs_data_a id 1
  464/1392 objects degraded (33.333%)

pool cephfs_metadata_a id 2
  21/63 objects degraded (33.333%)

Signed-off-by: Chang Liu liuchang0812@gmail.com

varadakari
varadakari approved these changes Jan 19, 2018
View reviewed changes
Copy link
Contributor

@varadakari varadakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tchaikov tchaikov self-requested a review January 19, 2018 15:37
@tchaikov
Copy link
Contributor

tchaikov commented Jan 23, 2018 •
edited

BTW, the param name of delta_sum of PGMapDigest::recovery_summary() is misleading too. delta_sum fits the recovery_rate_summary() well, but not recovery_summary().

@liuchang0812
mon: use pool_sum as param name in PGMapDigest::recovery_summary
73ff298 
the param name of delta_sum of PGMapDigest::recovery_summary() is misleading too.
delta_sum fits the recovery_rate_summary() well, but not recovery_summary().

Signed-off-by: Chang Liu <liuchang0812@gmail.com>
@liuchang0812
Copy link
Contributor Author 

BTW, the param name of delta_sum of PGMapDigest::recovery_summary() is misleading too. delta_sum fits the recovery_rate_summary() well, but not recovery_summary().

@tchaikov agree with you, I have renamed delta_sum to pool_sum in 73ff298, how about?

@tchaikov
Copy link
Contributor

@tchaikov tchaikov merged commit c641b20 into ceph:master Jan 26, 2018
@liuchang0812 liuchang0812 deleted the fix-22727 branch January 26, 2018 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchaikov tchaikov tchaikov approved these changes

@varadakari varadakari varadakari approved these changes

Assignees
No one assigned
Labels
bug-fix mon needs-qa wip-kefu-testing
Projects
None yet
Milestone
No milestone
4 participants
@liuchang0812 @tchaikov @varadakari @batrick