common/options,librbd/Utils: refactor RBD feature validation #20014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liewegas
force-pushed
the
wip-rbd-validate
branch
from
441b5b7
to
900fe2b
Compare
|
liewegas
force-pushed
the
wip-rbd-validate
branch
2 times, most recently
from
08007ca
to
ade3237
Compare
Move conversion of RBD features to/from string/uint64_t to helpers, and use those from the option validator. Keep the resulting features in integer form to avoid breaking Cinder. Meh. Change behavior from prior version: - fail to parse if any of the specified features is invalid (previously we would parse the ones we understood and ignore the others). Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-rbd-validate
branch
from
ade3237
to
fa2faee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move conversion of RBD features to/from string/uint64_t to helpers, and
use those from the option validator.
Keep the resulting features in integer form to avoid breaking Cinder.
Meh.
Signed-off-by: Sage Weil sage@redhat.com