mgr/dashboard: add configuration setting browser #20043
Conversation
Rubab-Syed
force-pushed
the
configuration_setting_browser
branch
from
884dcf4
to
21bfa8c
Compare
|
|
| @@ -187,9 +187,13 @@ PyObject *ActivePyModules::get_python(const std::string &what) | |||
| } | |||
| }); | |||
| return f.get(); | |||
| } else if (what == "config") { | |||
| } else if (what.substr(0, 6) == "config") { | |||
There was a problem hiding this comment.
what.startswith("config") would be clearer
There was a problem hiding this comment.
I think I will have to add some C++ library for this. Should I use boost or something?
There was a problem hiding this comment.
Silly me, I thought I was reading python. Never mind, this can stay as is!
| content_data.options_list = content_data.options.options; | ||
| } | ||
| for (var opt of content_data.options.options) { | ||
| if (service == "any" && opt.level == level) { |
There was a problem hiding this comment.
When someone selects a level, they should also get all the lower levels (i.e. if I select "advanced" then it should show both advanced and basic options)
| <thead> | ||
| <tr> | ||
| <th>Name</th> | ||
| <th>desc</th> |
There was a problem hiding this comment.
Column headers should be full words where reasonable (i.e. Description rather than dec)
| <div class="box" style="overflow:auto"> | ||
| <div class="box-body"> | ||
| <table class="table table-bordered"> | ||
| <thead> |
There was a problem hiding this comment.
As we discussed, I think this table needs some constraints on the widths of columns so that really long names don't push the whole thing out too far.
src/common/config.cc
Outdated
| f->open_array_section("options"); | ||
| for (const auto& i: schema) { | ||
| const Option &opt = i.second; | ||
| f->open_object_section("option"); |
There was a problem hiding this comment.
The Option class has a dump method that you can use instead of dumping all fields explicitly here.
Signed-off-by: Rubab Syed<rubab.syed21@gmail.com>
Rubab-Syed
force-pushed
the
configuration_setting_browser
branch
from
21bfa8c
to
14bb815
Compare
|
@Rubab-Syed @jcsp @smithfarm, dashboard_v2 relies on This commit does not alter any behaviour to the existing Ceph components, it simply adds the new Any objection to this backporting to Luminous for the ongoing dashboard_v2 backporting #23271? |
|
No objection from me |
http://tracker.ceph.com/issues/22522