mon: fix mgr using auth_client_required policy #20048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This caused mgr daemons to fail to authenticate when auth_client_required was set to something different to auth_cluster_required. Fixes: https://tracker.ceph.com/issues/22096 Signed-off-by: John Spray <john.spray@redhat.com>
tchaikov
approved these changes
Jan 23, 2018
jecluis
approved these changes
Jan 23, 2018
Previously was using auth_cluster_required for all connections, which meant that if someone had disabled client cephx, they'd get BADAUTHORIZER from their CLI when it tried to load mgr command descriptions. Disabling cephx on the admin CLI is odd, but the mon tolerates it so the mgr should too. Fixes: https://tracker.ceph.com/issues/22096 Signed-off-by: John Spray <john.spray@redhat.com>
|
Added a commit to make mgr handle client connections according to auth_client_required rather than auth_cluster_required |
tchaikov
approved these changes
Jan 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused mgr daemons to fail to authenticate
when auth_client_required was set to something
different to auth_cluster_required.
Fixes: https://tracker.ceph.com/issues/22096
Signed-off-by: John Spray john.spray@redhat.com