Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os/bluestore: make bdev label parsing error more meaningful and less noisy #20090

Merged
merged 2 commits into from Feb 1, 2018
Merged

os/bluestore: make bdev label parsing error more meaningful and less noisy #20090

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14c498d
os/bluestore: make bdev label parse error less noisy
liewegas Jan 24, 2018
5cd98b0
os/bluestore: change bdev parse error to ENOENT
liewegas Jan 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/os/bluestore/BlueStore.cc
View file
Open in desktop
Expand Up @@ -4200,10 +4200,10 @@ int BlueStore::_read_bdev_label(CephContext* cct, string path,
decode(expected_crc, p);
}
catch (buffer::error& e) {
derr << __func__ << " unable to decode label at offset " << p.get_off()
dout(2) << __func__ << " unable to decode label at offset " << p.get_off()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dout(1), still an error, not able to decode.

<< ": " << e.what()
<< dendl;
return -EINVAL;
return -ENOENT;
}
if (crc != expected_crc) {
derr << __func__ << " bad crc on label, expected " << expected_crc
Expand Down