os/bluestore: no need to fsync when failed to write label #20092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liewegas
changed the title
liewegas
reviewed
Jan 24, 2018
src/os/bluestore/BlueStore.cc
Outdated
| @@ -4160,6 +4160,8 @@ int BlueStore::_write_bdev_label(CephContext *cct, | |||
| if (r < 0) { | |||
| derr << __func__ << " failed to write to " << path | |||
| << ": " << cpp_strerror(r) << dendl; | |||
| VOID_TEMP_FAILURE_RETRY(::close(fd)); | |||
There was a problem hiding this comment.
Instead, can you 'goto out', and add an out: label on the VOID_TEMP_FAILURE... line below?
tangwenjun3
force-pushed
the
wip-fix-write-label
branch
3 times, most recently
from
257d169
to
3ebb5cc
Compare
tangwenjun3
changed the title
Signed-off-by: tangwenjun <tang.wenjun3@zte.com.cn>
|
@liewegas fixed |
liewegas
approved these changes
Jan 25, 2018
|
thanks, looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: tangwenjun tang.wenjun3@zte.com.cn