doc/dev: add a brief guide to serialization #20131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
reviewed
Jan 26, 2018
| if (struct_v >= 2) { | ||
| ::decode(member3, bl); | ||
| } | ||
| DECODE_FINISH(bl); |
There was a problem hiding this comment.
it's encouraged to support the new-style denc. see DENC(),DENC_START() and DENC_FINISH(). i can add a section for it once this change gets merged in.
tchaikov
approved these changes
Jan 26, 2018
smithfarm
reviewed
Jan 26, 2018
doc/dev/encoding.rst
Outdated
| :: | ||
| class AcmeClass | ||
| { | ||
| int member1; |
There was a problem hiding this comment.
For some reason, we're getting the following build error on this line:
Warning, treated as error:
/home/jenkins-build/build/workspace/ceph-pr-docs/doc/dev/encoding.rst:61:Unexpected indentation.
Contributors encounter this pretty soon when trying to add any feature to Ceph, so I'd like a central place to point them to. Ignoring feature bits etc for this simple example. Signed-off-by: John Spray <john.spray@redhat.com>
jcsp
force-pushed
the
wip-doc-encoding
branch
from
210d533
to
29b5611
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributors encounter this pretty soon when trying
to add any feature to Ceph, so I'd like a central place
to point them to.
Ignoring feature bits etc for this simple example.
Signed-off-by: John Spray john.spray@redhat.com