rgw_file: avoid evaluating nullptr for readdir offset #20145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've found by experimentation that passing a null pointer as a value to a CachedPrebufferedStreambuf ostream caused subsequent log prints to be squelched. (That's likely a bug, doesn't happen when the thread_local optimization change is reverted.) Fixes: https://tracker.ceph.com/issues/22820 Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
|
@aclamk when you have time, can you think how this type of behavior might occur, and how to make the cached ostreams recover from it? |
|
@mattbenjamin @aclamk writing |
|
@cbodley did you see a technical problem with this change? It doesn't purport to fix the stream problem in general, but does fix an output bug |
cbodley
approved these changes
Feb 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found by experimentation that passing a null pointer
as a value to a CachedPrebufferedStreambuf ostream caused
subsequent log prints to be squelched.
(That's likely a bug, doesn't happen when the thread_local
optimization change is reverted.)
Fixes: https://tracker.ceph.com/issues/22820
Signed-off-by: Matt Benjamin mbenjamin@redhat.com