mgr/balancer: pool-specific optimization support and bug fixes #20154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This currently only works for upmap. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
xiexingguo
force-pushed
the
wip-mgr-balancer-fixes
branch
from
b4668b0
to
bce4fbf
Compare
runsisi
reviewed
Jan 29, 2018
src/pybind/mgr/balancer/module.py
Outdated
| @@ -675,8 +691,8 @@ def do_crush_compat(self, plan): | |||
| overlap[osd] = 1 | |||
| visited[osd] = 1 | |||
| if len(overlap) > 0: | |||
| self.log.err('error: some osds belong to multiple subtrees: %s' % | |||
| overlap) | |||
| self.log.error('error: some osds belong to multiple subtrees: %s' % | |||
There was a problem hiding this comment.
this has been fixed by #20130 :)
liewegas
approved these changes
Jan 29, 2018
xiexingguo
force-pushed
the
wip-mgr-balancer-fixes
branch
from
bce4fbf
to
52e336e
Compare
…Eval Otherwise there might be obsolete pool/root infos etc. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
|
@xiexingguo shall we backport 52e336e to luminous? IMO, it's a bug fix of balancer mgr plugin. the same applies to #20180. |
|
@xiexingguo thanks in advance. |
|
thanks @xiexingguo ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.