os/bluestore: disable on_applied sync_complete #20169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. This is causing problems in ECBackend that are not obvious. 2. It didn't show any performance win anyway. 3. I'm trying to remove on_applied callbacks entirely. If that works out this will all be moot! Fixes: http://tracker.ceph.com/issues/22668 Signed-off-by: Sage Weil <sage@redhat.com>
…acks" This reverts commit 1908c06. Hoping this helps resolve the failed assertion src/osd/ExtentCache.h: 371: FAILED assert(tid == 0) Signed-off-by: Sage Weil <sage@redhat.com>
|
let's run it through the whole suite, too! |
gregsfortytwo
approved these changes
Feb 3, 2018
There was a problem hiding this comment.
I like simple fixes. Especially when they take advantage of other work to overcome their shortcomings. 👍
Reviewed-by: Greg Farnum gfarnum@redhat.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this will all be moot!
Fixes: http://tracker.ceph.com/issues/22668
Signed-off-by: Sage Weil sage@redhat.com