Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa/workunits/rbd: remove "trash purge --threshold" test #20170

Merged
merged 1 commit into from Feb 2, 2018

Conversation

trociny
Copy link
Contributor

@trociny trociny commented Jan 29, 2018

before running "rbd trash purge --threshold 0" test.

Fixes: http://tracker.ceph.com/issues/22803
Signed-off-by: Mykola Golub mgolub@suse.com

Copy link

@dillaman dillaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dillaman
Copy link

@trociny I guess it needs longer than 30 seconds [1] -- maybe time out after 2 minutes.

[1] http://qa-proxy.ceph.com/teuthology/jdillaman-2018-01-30_16:03:05-rbd-wip-jd-testing-distro-basic-smithi/2129127/teuthology.log

@trociny
Copy link
Contributor Author

trociny commented Jan 31, 2018

@dillaman updated. I am going to run this on teuthology.

@trociny
Copy link
Contributor Author

trociny commented Jan 31, 2018

It still fails [1]. I saw two causes:

  1. rbd default data pool is set, and in this case my calculation for BYTES_USED is wrong. (BTW, rbd trash purge --threshold does not also take into account that data can be in a data pool)

  2. small cache pool is used, and in this case the pool bytes_used never reach the expected value (probably because some objects are flushed out).

Also there was a failure on deep copy test because it tried to copy to old format destination image, but this is a different story.

[1] http://pulpito.ceph.com/trociny-2018-01-31_20:28:15-rbd-wip-mgolub-testing-distro-basic-smithi/

@trociny
Copy link
Contributor Author

trociny commented Jan 31, 2018

small cache pool is used, and in this case the pool bytes_used never reach the expected value (probably because some objects are flushed out).

Actually, I am calculating BYTES_USED in rbd, not cache, pool. So, not sure why it reported less bytes than I expected [1].

[1] http://qa-proxy.ceph.com/teuthology/trociny-2018-01-31_20:28:15-rbd-wip-mgolub-testing-distro-basic-smithi/2134105/teuthology.log

@trociny
Copy link
Contributor Author

trociny commented Feb 1, 2018

@dillaman Taking that --threshold can't be reliable and will only give "approximate" result for the user (probably satisfactory enough to be useful in usual scenarios), may be just remove --threshold test from test_purge()?

@dillaman
Copy link

dillaman commented Feb 1, 2018

@trociny

may be just remove --threshold test from test_purge()?

Given all the trouble it's causing, that sounds good to me.

It is difficult to make it work reliably in different environments.

Fixes: http://tracker.ceph.com/issues/22803
Signed-off-by: Mykola Golub <mgolub@suse.com>
@trociny trociny changed the title qa/workunits/rbd: wait for pool usage stats updated qa/workunits/rbd: remove "trash purge --threshold" test Feb 1, 2018
@trociny
Copy link
Contributor Author

trociny commented Feb 1, 2018

@dillaman updated

@dillaman dillaman merged commit bba63db into ceph:master Feb 2, 2018
@trociny trociny deleted the wip-22803 branch February 2, 2018 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants