os: unify Sequencer and CollectionHandle #20173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liewegas
force-pushed
the
wip-os-ch
branch
4 times, most recently
from
ffa516c
to
754de98
Compare
liewegas
force-pushed
the
wip-os-ch
branch
3 times, most recently
from
8ad8a25
to
cee56d3
Compare
These are stale and superceded by the fio ObjectStore (and other) backends. Shed the weight! Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
This relies on smalliobench, which is gone now. The task could pretty easily be resurrected if we substitute in another tool. Signed-off-by: Sage Weil <sage@redhat.com>
Stale test code, never run. Signed-off-by: Sage Weil <sage@redhat.com>
In practice we have a sequencer per collection. Combine them in the interface to simplify our lives! Signed-off-by: Sage Weil <sage@redhat.com>
Drop the coll_t shims, and convert the last few that weren't already handle-based. Signed-off-by: Sage Weil <sage@redhat.com>
This takes the (awkward) burden off the caller. Signed-off-by: Sage Weil <sage@redhat.com>
The ObjectStore implementation should handle this. Signed-off-by: Sage Weil <sage@redhat.com>
These are no longer needed as the implementations do it themselves. Signed-off-by: Sage Weil <sage@redhat.com>
This was used only to name the osr for the purposes of the tracepoint. We can do that ourselves! Signed-off-by: Sage Weil <sage@redhat.com>
No longer used! (It was only needed for an ugly FileStore hack.) Signed-off-by: Sage Weil <sage@redhat.com>
- start pool at 1 - make hash fall within pg (just match it for now) Signed-off-by: Sage Weil <sage@redhat.com>
|
http://pulpito.ceph.com/sage-2018-02-06_02:59:41-rados-wip-sage-testing-2018-02-05-1819-distro-basic-smithi |
jdurgin
approved these changes
Feb 7, 2018
| @@ -7234,6 +7234,7 @@ int BlueStore::collection_list( | |||
| vector<ghobject_t> *ls, ghobject_t *pnext) | |||
| { | |||
| Collection *c = static_cast<Collection *>(c_.get()); | |||
| c->flush(); | |||
There was a problem hiding this comment.
There's a comment in PG::_deleting_some() that this commit obviates.
There was a problem hiding this comment.
i'll clean that out in teh next pr
src/osd/PrimaryLogPG.cc
Outdated
| @@ -11654,7 +11654,6 @@ void PrimaryLogPG::shutdown() | |||
| lock(); | |||
| on_shutdown(); | |||
| unlock(); | |||
| ch->flush(); | |||
There was a problem hiding this comment.
I didn't look at everything yet so I probably just missed it, but what change to the ObjectStores makes them flush on shutdown?
There was a problem hiding this comment.
both bluestore and filestore already have machinery in umount() that flushes stuff that's in flight--no changes needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There should be no functional change here.