rgw: beast frontend can listen on multiple endpoints #20188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this allows us to configure multiple values for a given key without resorting to string formatting to cram them into a single key/value pair ex. port=80 port=443s instead of port=80+443s Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
rzarzynski
reviewed
Jan 31, 2018
src/rgw/rgw_asio_frontend.cc
Outdated
| return port; | ||
| } | ||
|
|
||
| tcp::endpoint parse_endpoint(std::experimental::string_view input, |
There was a problem hiding this comment.
Does Ceph have any policy on std::experimental? What about using boost::string_view instead?
There was a problem hiding this comment.
ah, thanks for reminding me about this part
i had found that boost::asio::ip::make_address() wouldn't accept boost::string_view or std::string_view, so this was the only form that would compile. but now that i look closer (http://www.boost.org/doc/libs/1_66_0/boost/asio/detail/string_view.hpp), there are typedefs for string_view/basic_string_view in namespace boost::asio that i can use instead
rgw_frontends options port= and endpoint= can be given multiple times, and the beast frontend will listen on each endpoint Fixes: http://tracker.ceph.com/issues/22779 Signed-off-by: Casey Bodley <cbodley@redhat.com>
cbodley
force-pushed
the
wip-rgw-frontend-multimap
branch
from
02a87c8
to
1bff073
Compare
|
thanks @rzarzynski, updated to use the same |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extends the frontend configuration to store options in a multimap, so that
portandendpointcan be specified multiple times. the beast frontend creates a separateListenerfor each port/endpoint given, and thisListenerinstance is passed as an extra argument whenaccept()ing new connections. the civetweb frontend also supports multipleportoptionsFixes: http://tracker.ceph.com/issues/22779