rbd: group misc cleanup and update rbd man page #20199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: songweibin <song.weibin@zte.com.cn>
Signed-off-by: songweibin <song.weibin@zte.com.cn>
Signed-off-by: songweibin <song.weibin@zte.com.cn>
Signed-off-by: songweibin <song.weibin@zte.com.cn>
Signed-off-by: songweibin <song.weibin@zte.com.cn>
Signed-off-by: songweibin <song.weibin@zte.com.cn>
dillaman
reviewed
Jan 31, 2018
src/librbd/api/Group.cc
Outdated
| @@ -731,7 +731,7 @@ int Group<I>::snap_create(librados::IoCtx& group_ioctx, | |||
| ldout(cct, 1) << "Failed to create io context for image" << dendl; | |||
| } | |||
|
|
|||
| ldout(cct, 20) << "Openning image with id" << image.spec.image_id << dendl; | |||
| ldout(cct, 20) << "Openning image with id " << image.spec.image_id << dendl; | |||
There was a problem hiding this comment.
Nit: can you correct the spelling of “opening” while you are changing this line?
dillaman
reviewed
Jan 31, 2018
src/librbd/api/Group.cc
Outdated
| break; | ||
| } | ||
| if (snap.name == new_snap_name) { | ||
| return -EEXIST; |
There was a problem hiding this comment.
This is (supposed to be) handled by cls_client::group_snap_set
* Add some error message when returning a negative error code. * Validate dest name when renaming a group snap. Signed-off-by: songweibin <song.weibin@zte.com.cn>
Songweibin
force-pushed
the
wip-group-cleanup
branch
from
30de8ce
to
0e69d4f
Compare
|
@dillaman Updated, thank you. |
dillaman
approved these changes
Feb 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.