client: add cap_dirtier_uid/gid to CapSnap #20200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set new fields to whatever the inode has at the time that we create the CapSnap. In the event that it was unset at the time of the creation and becomes dirty afterward, we set it again at finish. This ensures that we send a valid uid/gid in the event that it had dirty caps at any point during that period. Tracker: http://tracker.ceph.com/issues/22801 Signed-off-by: Jeff Layton <jlayton@redhat.com>
jtlayton
requested review from
batrick,
gregsfortytwo,
jcsp,
fullerdj and
ukernel
jtlayton
force-pushed
the
wip-jlayton-22801
branch
from
649308a
to
7a27551
Compare
ukernel
approved these changes
Feb 1, 2018
jcsp
approved these changes
Feb 2, 2018
gregsfortytwo
approved these changes
Feb 3, 2018
batrick
added a commit
that referenced
this pull request
Feb 8, 2018
* refs/pull/20200/head: client: add cap_dirtier_uid/gid to CapSnap Reviewed-by: John Spray <john.spray@redhat.com> Reviewed-by: Gregory Farnum <gfarnum@redhat.com> Reviewed-by: Zheng Yan <zyan@redhat.com> Reviewed-by: Greg Farnum <gfarnum@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and set it according to how it's set in the inode at the time that
we create the CapSnap. In the event that it becomes newly dirty at
the time we finish_cap_snap, then we copy those values over again.
Tracker: http://tracker.ceph.com/issues/22801
Signed-off-by: Jeff Layton jlayton@redhat.com