mon/OSDMonitor: Comment out unused function #20275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@badone why are we commenting these functions instead of removing them? |
badone
force-pushed
the
wip-osdmonitor-unused-function
branch
from
eb2de74
to
b77dedb
Compare
|
@jecluis I guess just following the precedent set when get_osd_up_pgs was commented out but I agree we should just dispense with these. |
|
for posterity, the upgrade-specific bits were dropped in 81bee4c. |
tchaikov
approved these changes
Feb 5, 2018
liewegas
approved these changes
Feb 5, 2018
jecluis
approved these changes
Feb 5, 2018
|
@badone needs rebase. |
Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
badone
force-pushed
the
wip-osdmonitor-unused-function
branch
from
b77dedb
to
ed7a744
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Brad Hubbard bhubbard@redhat.com