ceph_test_filestore_idempotent_sequence: many fixes #20279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This keeps our output separate from the filestore log, which we send to a file so that the terminal output is readable. Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
The old code made no sense whatsoever! - create one colletion, not a zillion - inform the model in the parent class Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
We need some initial objects for this to work. Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-idempotent-sequence
branch
2 times, most recently
from
60bc5bd
to
730c388
Compare
We want to get past the initial colleciton and object creation steps, which don't include interesting ops. Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
These were not guarded, meaning they could get replayed onto an object that was cloned or renamed. Eek! Fixes: http://tracker.ceph.com/issues/22920 Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-idempotent-sequence
branch
from
50ee96a
to
6f5a952
Compare
jdurgin
approved these changes
Feb 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tool was pretty broken and the tests weren't testing anything.
Most importantly, this includes a fix for a bug exposed in FileStore where omap ops aren't guarded during replay: http://tracker.ceph.com/issues/22920