cephfs-journal-tool event get list added output 'event time' #20346
Conversation
Signed-off-by: wang yong <wang.yong@datatom.com>
|
Can anybody help to review it? |
There was a problem hiding this comment.
First of all, thanks for contributing to Ceph.
This PR is targeting the wrong branch - should be "master".
Once the commit is in master, it can be cherry-picked to luminous and jewel.
To make that happen, open a tracker issue and fill in "luminous, jewel" into the "Backports" field.
Then, add a line saying "Fixes: https://tracker.ceph.com/issues/$ISSUE_NUMBER" to the commit.
Please also read https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#preparing-and-sending-patches for more info.
|
Fixes: https://tracker.ceph.com/issues/23116 |
|
@smithfarm once I changed to pr into branch master, there are a lot of files showned changed. should I close this PR,and copy codes to charmingcow/master then make a PR again? |
|
@charmingcow It's probably easier to start over and make a new PR targeting master, yes. And the "Fixes: https://tracker.ceph.com/issues/23116" line should be in the commit message (not just a comment in the PR). |
|
@charmingcow I see you opened #20580 so I'll close this now. |
add event timestamp for tool output is useful, such as analyze the damaged mds journal
cephfs-journal-tool event get list
0x400000 SUBTREEMAP: ()
cephfs-journal-tool event get list
2018-02-07 12:37:02.417835 0x400000 SUBTREEMAP: ()
Signed-off-by: "Wang,Yong" wang.yong@datatom.com