Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rgw: s3 copy object return 'x-amz-copy-source-version-id' and 'x-amz-version-id' #20348

Closed
wants to merge 1 commit into from
Closed

rgw: s3 copy object return 'x-amz-copy-source-version-id' and 'x-amz-version-id' #20348

wants to merge 1 commit into from

Conversation

fangyuxiangGL
Copy link
Contributor

No description provided.

@mattbenjamin mattbenjamin self-assigned this Feb 7, 2018
mattbenjamin
mattbenjamin reviewed Feb 7, 2018
View reviewed changes
Copy link
Contributor

@mattbenjamin mattbenjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good; could you create a tracker issue which this fixes, put tracker link in commit msg, and -consider- writing an s3-test which checks for these?

src/rgw/rgw_op.cc Outdated
@@ -4551,15 +4555,15 @@ void RGWCopyObj::execute()
&mtime,
mod_ptr,
unmod_ptr,
high_precision_time,
high_precision_time,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spacing change

src/rgw/rgw_op.cc Outdated
if_match,
if_nomatch,
attrs_mod,
copy_if_newer,
copy_if_newer,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spacing change

src/rgw/rgw_op.cc Outdated
attrs, RGW_OBJ_CATEGORY_MAIN,
olh_epoch,
(delete_at ? *delete_at : real_time()),
(version_id.empty() ? NULL : &version_id),
&dst_version_id,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happens to the former NULL case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think version_id.empty() is enough, and it might be more proper to use string &version instead of string *version for RGWRados::copy_obj

@fangyuxiangGL
rgw: s3 copy object support 'x-amz-copy-source-version-id' and 'x-amz…
d10f0a7 
…-version-id' in response

Fixes: http://tracker.ceph.com/issues/22946

Signed-off-by: fang yuxiang <fang.yuxiang@eisoo.com>
@fangyuxiangGL
Copy link
Contributor Author

@mattbenjamin
Fixes: http://tracker.ceph.com/issues/22946
I will add a case to s3test, thanks.

@fangyuxiangGL fangyuxiangGL mentioned this pull request Feb 9, 2018
Open
@fangyuxiangGL
Copy link
Contributor Author

@mattbenjamin
test case: ceph/s3-tests#211

@fangyuxiangGL
Copy link
Contributor Author

fangyuxiangGL commented Feb 22, 2018 •
edited

ping @mattbenjamin @cbodley

Could we do something for this?

@stale
Copy link

stale bot commented Oct 18, 2018

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you are a maintainer or core committer, please follow-up on this issue to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@stale stale bot added the stale label Oct 18, 2018
@mattbenjamin
Copy link
Contributor

unstale me my man

@stale stale bot removed the stale label Oct 18, 2018
@stale
Copy link

stale bot commented Dec 17, 2018

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you are a maintainer or core committer, please follow-up on this issue to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@stale stale bot added the stale label Dec 17, 2018
@stale
Copy link

stale bot commented Apr 22, 2019

This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution!

@stale stale bot closed this Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattbenjamin mattbenjamin mattbenjamin left review comments

Assignees

@mattbenjamin mattbenjamin

Labels
bug-fix rgw stale
Projects
None yet
Milestone
No milestone
2 participants
@fangyuxiangGL @mattbenjamin