Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbd-mirror: fix potential infinite loop when formatting status message #20349

Merged
merged 1 commit into from Feb 9, 2018

Commits on Feb 7, 2018

  1. rbd-mirror: fix potential infinite loop when formatting status message

    The improvements include:
    
    - tag_tid values should always be increasing, so loop only if
      master.tag_tid > mirror_tag_tid in calculate_behind_master_or_send_update;
    - in send_update_tag_cache don't refetch a tag if it is already in the
      cache;
    - make fake tags with tag_data.predecessor.tag_tid set to zero;
    - make sure the new tag is inserted to the cache if an old entry
      with this id happens to exist.
    
    Fixes: http://tracker.ceph.com/issues/22932
    Signed-off-by: Mykola Golub <mgolub@suse.com>
    trociny committed Feb 7, 2018
    Copy the full SHA
    2fb99b5 View commit details
    Browse the repository at this point in the history