msg/DispatchQueue: clear queue after wait() #20374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, how did that assert get in? Or is the use of a stop() to kill the daemon without processing messages new? |
|
I think this race has been there forever(ish) (note how old the bug is).
I hit it on the config branch with the
MonClient::get_monmap_and_config_privately(), which does a super short mon
session to fetch the monmap and config... I think it's just better at
hitting the race than any other code we have around.
|
The other queue_* methods check stop; enqueue() did not. Fixes: http://tracker.ceph.com/issues/18351 Signed-off-by: Sage Weil <sage@redhat.com>
|
retest this please |
|
@gregsfortytwo ok i found the real problem! much simpler than i thought before. this has held up fine over a weeks' work of rados runs and reruns. |
gregsfortytwo
approved these changes
Feb 20, 2018
|
Jenkins test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throw out new items after worker thread is stopped. All over enqueue_* methods were checking for stop except for this one.
Fixes: http://tracker.ceph.com/issues/18351
Signed-off-by: Sage Weil sage@redhat.com