test/librados: s/invoke_result_t/result_of_t/ #20379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
|
retest this please. |
|
@tchaikov I also tried including https://cplusplus.github.io/LWG/issue2807 sort of suggest that this can be/used to be an issue with Clang... |
|
@tchaikov |
|
On Fri, Feb 9, 2018 at 11:34 PM, Willem Jan Withagen < ***@***.***> wrote:
@tchaikov <https://github.com/tchaikov>
My install of the jenkins machine is last update 1 okt 2017.
Looked a bit in newer sources and it seems that there might be some fixes
in newer Clang stuff.
Will try to upgrade and see if that works.
yeah. issue 2807 is not marked completed yet. and the master branch libc++
has implemented most part of it, i'd say:
see
llvm-mirror/libcxx@e445521#diff-48f5ee43879b5ad38888f0a6ead10113
,
but i don't think the latest release of libc++ or llvm includes this
change. i will post a change to use std::result_of_t later on to workaround
this issue.
—
… You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#20379 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AADmv2_O0ycM-xRxOnP3AORGSZW7P3O7ks5tTGWNgaJpZM4R_X0q>
.
--
Regards
Kefu Chai
|
to workaround buggy libc++ implementation. see https://cplusplus.github.io/LWG/issue2807 . we should switch to invoke_result_t once issue2807 is fixed in the latest release of libc++. Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-test-fix-freebsd
branch
from
92fe770
to
df8b1c2
Compare
tchaikov
changed the title
|
@wjwithagen updated and repushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to workaround buggy libc++ implementation. see
https://cplusplus.github.io/LWG/issue2807 . we should switch to
invoke_result_t once issue2807 is fixed in the latest release of
libc++.
Signed-off-by: Kefu Chai kchai@redhat.com