[DNM] rgw: REST APIs for AWS Groups. #20383

pritha-srivastava · 2018-02-09T07:05:05Z

Added code for REST APIs for manipulation of AWS Groups.
This PR is a continuation of PR 16077.

Currently admin users in rgw are allowed to create/ delete/ update groups. (User Policies for the same is not in place)

adamemerson

This looks good so far.

Make sure to replace uses of ::encode/::decode with encode/decode so as not to break namespace stuff.

You may wish to rebase and compact things a bit since this goes over a relatively long timespan it would be easier to keep track of if older commits that were later changed were consolidated, but that's purely optional.

This is excellent so far.

One minor nit, why do we have the ARN stored explicitly as part of the group? That /should/ (I'd think) be derivable from the tenant and group name, unless I'm missing something.

src/rgw/rgw_group.h

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>

src/rgw/rgw_iam_policy.h

stale · 2018-10-18T03:54:03Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you are a maintainer or core committer, please follow-up on this issue to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

mattbenjamin · 2018-10-18T12:46:24Z

@pritha-srivastava @adamemerson is this still in holding pattern?

stale · 2018-12-17T16:57:24Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you are a maintainer or core committer, please follow-up on this issue to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

stale · 2019-04-22T17:34:37Z

This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution!

mattbenjamin · 2019-04-22T18:08:11Z

unstale for review

mattbenjamin · 2022-01-19T16:59:40Z

reopening for discussion

github-actions · 2022-01-19T16:59:46Z

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

adamemerson

I approve of this PR!

adamemerson · 2022-01-21T21:14:10Z

doc/radosgw/group.rst

+
+An example of a Bucket Policy to list a bucket and its contents with Principal
+set to a Group ARN is below::
+


We should probably note that this is NOT valid on AWS even if it is for us. Otherwise it might bite people doing multicloud.

(We /may/ want to consider having a 'compatibility' mode that rejects behaviors like this that we support that AWS doesn't, but I'm not sure how important that is.)

adamemerson · 2022-01-21T21:15:58Z

doc/radosgw/group.rst

+Limitations
+===========
+
+Currently, we do not support the REST APIs for Group operations.


This is no longer the case as of 7a8617c ?

adamemerson · 2022-01-21T21:54:03Z

src/rgw/rgw_json_enc.cc

@@ -474,6 +474,7 @@ void RGWUserInfo::dump(Formatter *f) const
    break;


Things aren't going in rgw_json_enc.cc any more since 2414c75 . They should just go in the corresponding .cc files for their headers.

(I think this will result in linker errors if left unmodified.)

adamemerson · 2022-01-21T22:00:44Z

src/rgw/rgw_rest_group.h

+
+class RGWRestGroup : public RGWRESTOp {
+protected:
+  string group_name;


We don't have using namespace std in headers any more, so this should be std::

adamemerson · 2022-01-21T22:03:05Z

src/rgw/rgw_user.h

+/**
+ * Add group name to user info
+ */
+extern bool rgw_add_group_to_user(RGWUserInfo& info, const string& group_name);


We should probably stop sticking extern on function prototypes since it's the default.

adamemerson · 2022-01-21T22:14:24Z

Does this have tests that can exercise it already in s3tests that we just have to enable? Or does it need tests?

github-actions · 2022-07-07T02:16:41Z

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

anthonyeleven

I left some formatting and wording requests, and Adam entered some unresolved notes as well.

anthonyeleven · 2022-07-10T00:15:37Z

doc/radosgw/group.rst

+Groups
+===============
+
+Ceph Object Gateway provides support for Amazon Groups. A group is a collection


The Ceph Object Gateway (RGW) provides support for Amazon S3 groups. A group is a collection of users.

Below, what does ARN mean?

anthonyeleven · 2022-07-10T00:16:36Z

doc/radosgw/group.rst

+Group Management
+====================
+
+A group can be created/ deleted/ updated and users can be added to /removed


A group may be created, deleted, or updated and users added or removed from a group with radosgw-admin commands.

anthonyeleven · 2022-07-10T00:16:53Z

doc/radosgw/group.rst

+Update a Group
+--------------
+
+To update the name/ path of a group, execute the following::


The name or path of a group

anthonyeleven · 2022-07-10T00:17:48Z

src/test/cli/radosgw-admin/help.t

+     --path                    path to the group
+     --path-prefix             path prefix for filtering groups
+     --new-group-name          new name of an existing group
+     --new-path                new path of an existing group


s/of/for/ ?

github-actions · 2022-09-13T13:16:27Z

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

mattbenjamin · 2022-09-13T13:35:12Z

un-stahl

github-actions · 2022-11-12T15:01:36Z

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

github-actions · 2022-12-12T16:01:38Z

This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution!

pritha-srivastava added feature rgw labels Feb 9, 2018

pritha-srivastava requested a review from adamemerson February 9, 2018 07:05

adamemerson reviewed Feb 14, 2018

View reviewed changes

src/rgw/rgw_group.h Outdated Show resolved Hide resolved

pritha-srivastava added 7 commits February 15, 2018 19:57

rgw: Initial commit for RGWGroup class.

1632ea7

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>

rgw: Code for AWS group related cli commands.

10e97b8

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>

rgw: Tying up groups with auth framework.

1c8cedc

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>

rgw: Correcting logic for parsing Principals that contain path.

0c9a226

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>

rgw: Addressing review comments.

89a9cc3

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>

rgw: Adding documentation for RGW Group.

1179fc5

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>

rgw: Code for REST APIs for AWS Groups.

7a8617c

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>

pritha-srivastava force-pushed the wip-rgw-groups-rest-api branch from 95decf5 to 7a8617c Compare February 20, 2018 09:01

pritha-srivastava commented Feb 20, 2018

View reviewed changes

src/rgw/rgw_iam_policy.h Show resolved Hide resolved

stale bot added the stale label Oct 18, 2018

stale bot removed the stale label Oct 18, 2018

stale bot added the stale label Dec 17, 2018

stale bot closed this Apr 22, 2019

mattbenjamin reopened this Jan 19, 2022

github-actions bot added needs-rebase build/ops documentation tests labels Jan 19, 2022

stale bot removed the stale label Jan 19, 2022

adamemerson self-requested a review January 21, 2022 21:12

adamemerson approved these changes Jan 21, 2022

View reviewed changes

adamemerson added the needs-test label Jan 21, 2022

github-actions bot added the stale label Jul 7, 2022

cbodley mentioned this pull request Jul 7, 2022

rgw: user accounts implementation #46373

Closed

10 tasks

djgalloway changed the base branch from master to main July 10, 2022 00:00

djgalloway requested a review from a team as a code owner July 10, 2022 00:00

anthonyeleven requested changes Jul 10, 2022

View reviewed changes

github-actions bot removed the stale label Jul 15, 2022

github-actions bot added the stale label Sep 13, 2022

github-actions bot removed the stale label Sep 13, 2022

github-actions bot added the stale label Nov 12, 2022

github-actions bot closed this Dec 12, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DNM] rgw: REST APIs for AWS Groups. #20383

[DNM] rgw: REST APIs for AWS Groups. #20383

pritha-srivastava commented Feb 9, 2018

adamemerson left a comment

stale bot commented Oct 18, 2018

mattbenjamin commented Oct 18, 2018

stale bot commented Dec 17, 2018

stale bot commented Apr 22, 2019

mattbenjamin commented Apr 22, 2019

mattbenjamin commented Jan 19, 2022

github-actions bot commented Jan 19, 2022

adamemerson left a comment

adamemerson Jan 21, 2022

adamemerson Jan 21, 2022

adamemerson Jan 21, 2022

adamemerson Jan 21, 2022

adamemerson Jan 21, 2022

adamemerson commented Jan 21, 2022

github-actions bot commented Jul 7, 2022

anthonyeleven left a comment

anthonyeleven Jul 10, 2022

anthonyeleven Jul 10, 2022

anthonyeleven Jul 10, 2022

anthonyeleven Jul 10, 2022

github-actions bot commented Sep 13, 2022

mattbenjamin commented Sep 13, 2022

github-actions bot commented Nov 12, 2022

github-actions bot commented Dec 12, 2022


		An example of a Bucket Policy to list a bucket and its contents with Principal
		set to a Group ARN is below::

		@@ -474,6 +474,7 @@ void RGWUserInfo::dump(Formatter *f) const
		break;

[DNM] rgw: REST APIs for AWS Groups. #20383

[DNM] rgw: REST APIs for AWS Groups. #20383

Conversation

pritha-srivastava commented Feb 9, 2018

adamemerson left a comment

Choose a reason for hiding this comment

stale bot commented Oct 18, 2018

mattbenjamin commented Oct 18, 2018

stale bot commented Dec 17, 2018

stale bot commented Apr 22, 2019

mattbenjamin commented Apr 22, 2019

mattbenjamin commented Jan 19, 2022

github-actions bot commented Jan 19, 2022

adamemerson left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adamemerson commented Jan 21, 2022

github-actions bot commented Jul 7, 2022

anthonyeleven left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Sep 13, 2022

mattbenjamin commented Sep 13, 2022

github-actions bot commented Nov 12, 2022

github-actions bot commented Dec 12, 2022