New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rbd: resource agent needs to be executable #20397
Conversation
1d3cc31
to
9399f37
Compare
@tdb: Could you prefix the title of your commit message with the subcomponent your are changing? See https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#3-describe-your-changes . in this case, it could be "cmake" or "build/ops". |
Without this the resource fails in Pacemaker with the error: Feb 11 12:48:30 mypacemakerhost crmd[5154]: error: Failed to retrieve meta-data for ocf:ceph:rbd Feb 11 12:48:30 mypacemakerhost crmd[5154]: notice: Operation p_rbd_myres_monitor_0: insufficient privileges (node=mypacemakerhost, call=228, rc=4, cib-update=60, confirmed=true) This worked fine in the jewel version of the package, but is broken in the luminous one, presumably because of the build changes. Fixes: http://tracker.ceph.com/issues/22980 Signed-off-by: Tim Bishop <tim@bishnet.net>
9399f37
to
567d156
Compare
@smithfarm does that look better? |
"The PROGRAMS form is identical to the FILES form except that the default permissions for the installed file also include OWNER_EXECUTE, GROUP_EXECUTE, and WORLD_EXECUTE. This form is intended to install programs that are not targets, such as shell scripts. Use the TARGETS form to install targets built within the project." This fix falls under http://tracker.ceph.com/issues/22362 - I'll reopen it and stage the backport once this merges. |
Thanks. I did search the bug tracker beforehand but didn't find 22362. |
http://pulpito.ceph.com/smithfarm-2018-02-21_22:45:50-rados-wip-smithfarm-testing-distro-basic-smithi/ Summary: rados suite passes with one failure in rados/standalone/scrub.yaml - not clear to me why this is failing |
@dillaman Ready to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Without this the resource fails in Pacemaker with the error:
This worked fine in the jewel version of the package, but is broken in the luminous one, presumably because of the build changes.
Follow-on fix for http://tracker.ceph.com/issues/22362