luminous: mon: accept crush device class to osd new #20405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hides device names when they don't appear in the hierarchy, e.g. after setting a name and class for a new device that hasn't yet been put in the tree. Signed-off-by: Sage Weil <sage@redhat.com> (cherry picked from commit 1e48ee9)
We should set the max_devices value for a new device. (Actually, finalize() will fix this for us on decode, but better to be pendantic.) Signed-off-by: Sage Weil <sage@redhat.com> (cherry picked from commit 6aa7c88)
If provided, set the OSD device_class at OSD creation time. This is simpler than writing a file that the OSD has to read in and use to set its initial device class, and also avoids a bit of sticky state at the OSD that will make it keep trying to reset its device class on startup if it ever gets cleared. Note that we now ignore json input fields we don't understand, so remove a test case. Signed-off-by: Sage Weil <sage@redhat.com> (cherry picked from commit 59bdada)
2 tasks
alfredodeza
approved these changes
Feb 12, 2018
tchaikov
approved these changes
Feb 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.