librbd: fix issues discovered in clone v2 during upgrade tests #20406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trociny
reviewed
Feb 13, 2018
src/cls/rbd/cls_rbd.cc
Outdated
| if (r < 0 && r != -ENOENT) { | ||
| return r; | ||
| } | ||
| bool has_parent = (r != -ENOENT && parent.pool != -1); |
There was a problem hiding this comment.
nit (could be just ignored): r == 0 (or >= 0) looks a bit more appropriate to me here.
added 2 commits
February 13, 2018 09:14
After removing the last snapshot linked to a parent image, don't clear the CLONE_CHILD op feature bit if the image HEAD is still linked to the parent. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Fixes: http://tracker.ceph.com/issues/22979 Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.