librbd: new tag should use on-disk committed position #20423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
trociny
reviewed
Feb 14, 2018
src/journal/JournalMetadata.cc
Outdated
| --m_refreshes_in_progress; | ||
| if (m_refreshes_in_progress == 0) { | ||
| std::swap(refresh_ctxs, m_refresh_ctxs); | ||
| } |
There was a problem hiding this comment.
@dillaman I suppose it should be outside of if (r == 0) block.
Observing rbd_mirror.sh test failure, on "disable mirroring / delete non-primary image", due to image replayer shut_down hangs on m_remote_journaler->shut_down, when refresh mutable metadata returns r=-2 (for test3 or test5 image). See e.g. [1] but it is reproduced locally too.
[1] http://pulpito.ceph.com/trociny-2018-02-14_14:24:46-rbd-wip-mgolub-testing-distro-basic-smithi/
added 2 commits
February 14, 2018 11:22
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Fixes: http://tracker.ceph.com/issues/22945 Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.