Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph-volume use realpath when checking mounts #20427

Merged
merged 2 commits into from Feb 13, 2018

Conversation

Projects
None yet
2 participants
@alfredodeza
Copy link
Contributor

commented Feb 13, 2018

on 469d01d the realpath detection was removed as it would cause issues with dmcrypt, but this is needed to ensure mounts are detected.

This change improves on that with the 4 combinations of realpath vs. plain on devices and paths.

Fixes: http://tracker.ceph.com/issues/22988

@alfredodeza alfredodeza requested a review from andrewschoen Feb 13, 2018

@alfredodeza

This comment has been minimized.

Copy link
Contributor Author

commented Feb 13, 2018

jenkins test ceph-volume tox

@andrewschoen

This comment has been minimized.

Copy link
Contributor

commented Feb 13, 2018

jenkins test ceph-volume all

1 similar comment
@alfredodeza

This comment has been minimized.

Copy link
Contributor Author

commented Feb 13, 2018

jenkins test ceph-volume all

@alfredodeza

This comment has been minimized.

Copy link
Contributor Author

commented Feb 13, 2018

jenkins test ceph-volume lvm centos7-bluestore-dmcrypt

alfredodeza added some commits Feb 13, 2018

ceph-volume util.system optionally use realpath on devices
To check a mounted device it is needed to verify on a combination of
realpath and plain devices against realpath and plain paths. In LVM, two
different paths might refer to the same devices

Signed-off-by: Alfredo Deza <adeza@redhat.com>
ceph-volume tests verify realpath usage in mounts
Signed-off-by: Alfredo Deza <adeza@redhat.com>

@alfredodeza alfredodeza force-pushed the wip-rm22988 branch from dcecad4 to 16eabbc Feb 13, 2018

@andrewschoen

This comment has been minimized.

Copy link
Contributor

commented Feb 13, 2018

jenkins test ceph-volume tox

@andrewschoen

This comment has been minimized.

Copy link
Contributor

commented Feb 13, 2018

jenkins test ceph-volume all

@andrewschoen

This comment has been minimized.

Copy link
Contributor

commented Feb 13, 2018

jenkins test ceph-volume simple xenial-bluestore-dmcrypt_plain

@andrewschoen

This comment has been minimized.

Copy link
Contributor

commented Feb 13, 2018

jenkins test ceph-volume simple centos7-filestore-dmcrypt_luks

@andrewschoen

This comment has been minimized.

Copy link
Contributor

commented Feb 13, 2018

The tests lvm centos7-filestore-create and lvm xenial-filestore-create are expected to fail until #20265 is merged.

@andrewschoen andrewschoen merged commit 5f7c250 into master Feb 13, 2018

23 of 26 checks passed

ceph-volume lvm testing centos7-filestore-create ceph-volume lvm centos7-filestore-create failed
Details
ceph-volume lvm testing xenial-filestore-create ceph-volume lvm xenial-filestore-create failed
Details
make check (arm64) make check failed
Details
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
ceph-volume lvm testing centos7-bluestore-create ceph-volume lvm centos7-bluestore-create OK
Details
ceph-volume lvm testing centos7-bluestore-dmcrypt ceph-volume lvm centos7-bluestore-dmcrypt OK
Details
ceph-volume lvm testing centos7-filestore-dmcrypt ceph-volume lvm centos7-filestore-dmcrypt OK
Details
ceph-volume lvm testing xenial-bluestore-create ceph-volume lvm xenial-bluestore-create OK
Details
ceph-volume lvm testing xenial-bluestore-dmcrypt ceph-volume lvm xenial-bluestore-dmcrypt OK
Details
ceph-volume lvm testing xenial-filestore-dmcrypt ceph-volume lvm xenial-filestore-dmcrypt OK
Details
ceph-volume simple testing centos7-bluestore-activate ceph-volume simple centos7-bluestore-activate OK
Details
ceph-volume simple testing centos7-bluestore-dmcrypt_luks ceph-volume simple centos7-bluestore-dmcrypt_luks OK
Details
ceph-volume simple testing centos7-bluestore-dmcrypt_plain ceph-volume simple centos7-bluestore-dmcrypt_plain OK
Details
ceph-volume simple testing centos7-filestore-activate ceph-volume simple centos7-filestore-activate OK
Details
ceph-volume simple testing centos7-filestore-dmcrypt_luks ceph-volume simple centos7-filestore-dmcrypt_luks OK
Details
ceph-volume simple testing centos7-filestore-dmcrypt_plain ceph-volume simple centos7-filestore-dmcrypt_plain OK
Details
ceph-volume simple testing xenial-bluestore-activate ceph-volume simple xenial-bluestore-activate OK
Details
ceph-volume simple testing xenial-bluestore-dmcrypt_luks ceph-volume simple xenial-bluestore-dmcrypt_luks OK
Details
ceph-volume simple testing xenial-bluestore-dmcrypt_plain ceph-volume simple xenial-bluestore-dmcrypt_plain OK
Details
ceph-volume simple testing xenial-filestore-activate ceph-volume simple xenial-filestore-activate OK
Details
ceph-volume simple testing xenial-filestore-dmcrypt_luks ceph-volume simple xenial-filestore-dmcrypt_luks OK
Details
ceph-volume simple testing xenial-filestore-dmcrypt_plain ceph-volume simple xenial-filestore-dmcrypt_plain OK
Details
ceph-volume tox testing ceph-volume tox OK
Details
make check make check succeeded
Details

@andrewschoen andrewschoen deleted the wip-rm22988 branch Feb 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.