ceph-volume use realpath when checking mounts #20427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins test ceph-volume tox |
|
jenkins test ceph-volume all |
1 similar comment
|
jenkins test ceph-volume all |
|
jenkins test ceph-volume lvm centos7-bluestore-dmcrypt |
added 2 commits
February 13, 2018 15:55
To check a mounted device it is needed to verify on a combination of realpath and plain devices against realpath and plain paths. In LVM, two different paths might refer to the same devices Signed-off-by: Alfredo Deza <adeza@redhat.com>
Signed-off-by: Alfredo Deza <adeza@redhat.com>
alfredodeza
force-pushed
the
wip-rm22988
branch
from
dcecad4
to
16eabbc
Compare
|
jenkins test ceph-volume tox |
|
jenkins test ceph-volume all |
|
jenkins test ceph-volume simple xenial-bluestore-dmcrypt_plain |
|
jenkins test ceph-volume simple centos7-filestore-dmcrypt_luks |
|
The tests |
andrewschoen
approved these changes
Feb 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on 469d01d the realpath detection was removed as it would cause issues with dmcrypt, but this is needed to ensure mounts are detected.
This change improves on that with the 4 combinations of realpath vs. plain on devices and paths.
Fixes: http://tracker.ceph.com/issues/22988