Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os/bluestore: fix the demotion in StupidAllocator::init_rm_free #20430

Merged
merged 1 commit into from Feb 15, 2018
Merged

os/bluestore: fix the demotion in StupidAllocator::init_rm_free #20430

merged 1 commit into from Feb 15, 2018

Conversation

tchaikov
Copy link
Contributor

  • we should update the _size field when demotion kicks in, otherwise the
    interval_set::m and interval_set::_size won't be consistent.
  • also rename post_process to claim, as it "steals" the leftover(s) of
    chopped segment.

Signed-off-by: Kefu Chai kchai@redhat.com

@tchaikov
os/bluestore: fix the demotion in StupidAllocator::init_rm_free
d43c8da 
* we should update the _size field when demotion kicks in, otherwise the
  interval_set::m and interval_set::_size won't be consistent.
* also rename post_process to claim, as it "steals" the leftover(s) of
chopped segment.

Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov
Copy link
Contributor Author

tchaikov commented Feb 14, 2018 •
edited

see also 89aeea8

this should address the test failure of bin/unittest_bluefs --gtest_filter=BlueFS.test_replay on aarch64

ifed01
ifed01 approved these changes Feb 14, 2018
View reviewed changes
Copy link
Contributor

@ifed01 ifed01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tchaikov
Copy link
Contributor Author

tchaikov commented Feb 15, 2018 •
edited

http://pulpito.ceph.com/kchai-2018-02-15_15:55:27-rados-wip-kefu-testing-2018-02-15-0045-distro-basic-smithi/

the failed tests are not relevant.

@tchaikov tchaikov merged commit 57d1b78 into ceph:master Feb 15, 2018
@tchaikov tchaikov deleted the wip-bluefs-demotion branch February 15, 2018 18:26
@yuriw yuriw added the backport label May 20, 2018
@yuriw
Copy link
Contributor

yuriw commented May 20, 2018

@theanalyst we need it on luminous

@tchaikov
Copy link
Contributor Author

@yuriw @theanalyst see #21995

yanghonggang pushed a commit to yanghonggang/ceph that referenced this pull request Sep 17, 2019
@tchaikov
Merge pull request ceph#20430 from tchaikov/wip-bluefs-demotion
9524f20 
os/bluestore: fix the demotion in StupidAllocator::init_rm_free

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
(cherry picked from commit 57d1b78)

Conflicts:
	src/include/interval_set.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ifed01 ifed01 ifed01 approved these changes

@liewegas liewegas Awaiting requested review from liewegas

Assignees

@theanalyst theanalyst

Labels
bluestore bug-fix needs-qa wip-kefu-testing
Projects
None yet
Milestone
No milestone
4 participants
@tchaikov @yuriw @ifed01 @theanalyst