Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/bluestore: fix the demotion in StupidAllocator::init_rm_free #20430

Merged
merged 1 commit into from Feb 15, 2018

Conversation

Projects
None yet
4 participants
@tchaikov
Copy link
Contributor

commented Feb 14, 2018

  • we should update the _size field when demotion kicks in, otherwise the
    interval_set::m and interval_set::_size won't be consistent.
  • also rename post_process to claim, as it "steals" the leftover(s) of
    chopped segment.

Signed-off-by: Kefu Chai kchai@redhat.com

os/bluestore: fix the demotion in StupidAllocator::init_rm_free
* we should update the _size field when demotion kicks in, otherwise the
  interval_set::m and interval_set::_size won't be consistent.
* also rename post_process to claim, as it "steals" the leftover(s) of
chopped segment.

Signed-off-by: Kefu Chai <kchai@redhat.com>

@tchaikov tchaikov requested review from liewegas and ifed01 Feb 14, 2018

@tchaikov

This comment has been minimized.

Copy link
Contributor Author

commented Feb 14, 2018

see also 89aeea8

this should address the test failure of bin/unittest_bluefs --gtest_filter=BlueFS.test_replay on aarch64

@ifed01

ifed01 approved these changes Feb 14, 2018

Copy link
Contributor

left a comment

LGTM

@tchaikov

This comment has been minimized.

Copy link
Contributor Author

commented Feb 15, 2018

@tchaikov tchaikov merged commit 57d1b78 into ceph:master Feb 15, 2018

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@tchaikov tchaikov deleted the tchaikov:wip-bluefs-demotion branch Feb 15, 2018

@yuriw yuriw added the backport label May 20, 2018

@yuriw

This comment has been minimized.

Copy link
Contributor

commented May 20, 2018

@theanalyst we need it on luminous

@tchaikov

This comment has been minimized.

Copy link
Contributor Author

commented May 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.