Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: Allow swift acls to be deleted. #20471

Merged
merged 1 commit into from Feb 27, 2018

Conversation

Projects
None yet
6 participants
@mdw-at-linuxbox
Copy link
Contributor

commented Feb 18, 2018

The openstack "swift" command deletes acls by submitting an
acl with an empty string. The existing logic uses c++ strings,
which can't distinguish between an empty string and a non-existant
string. Additional, the strings are coming from RGWEnv which
supplies C strings not c++. Using C strings instead makes it
trivial to pass "non-existance" (as a null string). It also avoids
some type conversion with string copying.

Fixes: http://tracker.ceph.com/issues/22897

Signed-off-by: Marcus Watts mwatts@redhat.com

Allow swift acls to be deleted.
The openstack "swift" command deletes acls by submitting an
acl with an empty string.  The existing logic uses c++ strings,
which can't distinguish between an empty string and a non-existant
string.  Additional, the strings are coming from RGWEnv which
supplies C strings not c++.  Using C strings instead makes it
trivial to pass "non-existance" (as a null string).  It also avoids
some type conversion with string copying.

Fixes: http://tracker.ceph.com/issues/22897

Signed-off-by: Marcus Watts <mwatts@redhat.com>

@cbodley cbodley added needs-qa and removed needs-review labels Feb 19, 2018

@liewegas liewegas changed the title Allow swift acls to be deleted. rgw: Allow swift acls to be deleted. Feb 20, 2018

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2018

@yuriw yuriw merged commit 9cafa7c into ceph:master Feb 27, 2018

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.