rgw: Allow swift acls to be deleted. #20471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The openstack "swift" command deletes acls by submitting an acl with an empty string. The existing logic uses c++ strings, which can't distinguish between an empty string and a non-existant string. Additional, the strings are coming from RGWEnv which supplies C strings not c++. Using C strings instead makes it trivial to pass "non-existance" (as a null string). It also avoids some type conversion with string copying. Fixes: http://tracker.ceph.com/issues/22897 Signed-off-by: Marcus Watts <mwatts@redhat.com>
oritwas
approved these changes
Feb 18, 2018
liewegas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The openstack "swift" command deletes acls by submitting an
acl with an empty string. The existing logic uses c++ strings,
which can't distinguish between an empty string and a non-existant
string. Additional, the strings are coming from RGWEnv which
supplies C strings not c++. Using C strings instead makes it
trivial to pass "non-existance" (as a null string). It also avoids
some type conversion with string copying.
Fixes: http://tracker.ceph.com/issues/22897
Signed-off-by: Marcus Watts mwatts@redhat.com