Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include: compat.h, fix the return result of pthread_set_name() #20474

Merged
merged 1 commit into from Feb 19, 2018

Conversation

Projects
None yet
3 participants
@wjwithagen
Copy link
Contributor

commented Feb 18, 2018

On FreeBSD the function type is void(). Make it compatible with return
value on other platforms.

Signed-off-by: Willem Jan Withagen wjw@digiware.nl

include: compat.h, fix the return result of pthread_set_name()
On FreeBSD the function type is void(). Make it compatible with return
value on other platforms.

Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>

@wjwithagen wjwithagen requested a review from adamemerson Feb 18, 2018

@liewegas liewegas added the build/ops label Feb 18, 2018

/* Fix a small name diff and return 0 */
#define ceph_pthread_setname(thread, name) ({ \
pthread_set_name_np(thread, name); \
0; })

This comment has been minimized.

Copy link
@tchaikov

tchaikov Feb 18, 2018

Contributor

no need to do this on GNU/Linux.

This comment has been minimized.

Copy link
@wjwithagen

wjwithagen Feb 19, 2018

Author Contributor

@tchaikov
pthread_set_name_np is only found on FreeBSD.
Si I'd expect this to be only selected on FreeBSD.

This comment has been minimized.

@tchaikov tchaikov merged commit 3b10d16 into ceph:master Feb 19, 2018

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@wjwithagen wjwithagen deleted the wjwithagen:wjw-wip-pthread_set_name_2 branch Jan 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.