os/bluestore: prevent statfs available from going negative #20487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifed01
reviewed
Feb 19, 2018
src/os/bluestore/BlueStore.cc
Outdated
| @@ -6399,7 +6399,11 @@ int BlueStore::statfs(struct store_statfs_t *buf) | |||
| // part of our shared device is "free" according to BlueFS | |||
| // Don't include bluestore_bluefs_min because that space can't | |||
| // be used for any other purpose. | |||
| buf->available += bluefs->get_free(bluefs_shared_bdev) - cct->_conf->bluestore_bluefs_min; | |||
| int64_t shared_available = bluefs->get_free(bluefs_shared_bdev) - | |||
| cct->_conf->bluestore_bluefs_min; | |||
There was a problem hiding this comment.
IMO (if I understand bluestore_bluefs_min semantics properly) generally that's improper use of bluestore_bluefs_min. Consider two cases (when bluefs_shared_bdev = 1Gb):
- bluefs->get_total() = 2Gb and bluefs->get_free() = 0.5Gb. This should result in shared_available = 0.5Gb
- bluefs->get_total() = 2Gb and bluefs->get_free() = 1.5Gb => shared_available to be = 1Gb
So looks like one should take get_total() into account when adjusting using bluestore_bluefs_min.
I.e. something like
shared_available = min(get_free(), get_total() - bluestore_bluefs_min);
|
And as you're touching statfs function may be it makes sense to cherry-pick this commit We had some bug reports and corresponding discussion at dev-list about that a while ago.... |
Fixes: https://tracker.ceph.com/issues/23040 Signed-off-by: Sage Weil <sage@redhat.com>
… statfs method Signed-off-by: Igor Fedotov <ifedotov@suse.com>
ifed01
approved these changes
Feb 20, 2018
liewegas
added a commit
that referenced
this pull request
Feb 21, 2018
* refs/pull/20487/head: os/bluestore: do not account DB volume space in total one reported by statfs method os/bluestore: prevent statfs available from going negative Reviewed-by: Igor Fedotov <ifedotov@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/23040
Signed-off-by: Sage Weil sage@redhat.com