Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common/dns_resolv.cc: Query for AAAA-record if ms_bind_ipv6 is True #20530

Merged
merged 1 commit into from Feb 28, 2018

Conversation

wido
Copy link
Member

@wido wido commented Feb 22, 2018

Otherwise we always query for A-records which will not work in a IPv6
Ceph cluster.

Fixes: http://tracker.ceph.com/issues/23078

Signed-off-by: Wido den Hollander wido@42on.com

@wido wido added the common label Feb 22, 2018
@wido wido requested a review from tchaikov February 22, 2018 08:00
@wido wido added the bug-fix label Feb 22, 2018
@tchaikov
Copy link
Contributor

@wido

instead of using the notation of Fixes: #23078, could you put Fixes: http://tracker.ceph.com/issues/23078 ? because #23078 will conflict with the PR with the same number. otherwise, lgtm.

Otherwise we always query for A-records which will not work in a IPv6
Ceph cluster.

Fixes: http://tracker.ceph.com/issues/23078

Signed-off-by: Wido den Hollander <wido@42on.com>
@wido
Copy link
Member Author

wido commented Feb 22, 2018

Thanks @tchaikov

I fixed that in the commit as well, it now points to a URL

@tchaikov tchaikov merged commit d574e82 into ceph:master Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants