osd/ECBackend: inject sleep during deep scrub #20531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
See 588f064. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
liewegas
approved these changes
Feb 22, 2018
jdurgin
reviewed
Feb 22, 2018
| @@ -2356,6 +2356,10 @@ int ECBackend::be_deep_scrub( | |||
|
|
|||
| utime_t sleeptime; | |||
| sleeptime.set_from_double(cct->_conf->osd_debug_deep_scrub_sleep); | |||
| if (sleeptime != utime_t()) { | |||
| lgeneric_derr(cct) << __func__ << " sleeping for " << sleeptime << dendl; | |||
| sleeptime.sleep(); | |||
There was a problem hiding this comment.
this isn't a new problem, but it makes me notice that these sleeps need fixing - since scrub is being called from the op queue threads, sleeping like this blocks one of them.
They should be converted to async sleeps like in PG::scrub().
There was a problem hiding this comment.
nevermind, this is just a debug sleep
|
Thanks @tchaikov ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: xie xingguo xie.xingguo@zte.com.cn