librbd: minor cleanup of the IO pathway #20560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dillaman
force-pushed
the
wip-22960-1
branch
from
84f1446
to
dee3e6d
Compare
trociny
reviewed
Feb 26, 2018
src/librbd/io/ImageRequest.cc
Outdated
| journal_tid); | ||
| ctx = new C_FlushJournalCommit<I>(image_ctx, aio_comp, journal_tid); | ||
| ctx = new FunctionContext( | ||
| [aio_comp, &image_ctx, journal_tid, ctx] (int r) { |
There was a problem hiding this comment.
nit: aio_comp is not used here any more
src/librbd/io/ReadResult.cc
Outdated
| CephContext *cct = aio_completion->ictx->cct; | ||
| ldout(cct, 10) << "C_SparseReadRequestBase: r = " << r | ||
| ldout(cct, 10) << "C_ObjectReadRequest: r = " << r |
There was a problem hiding this comment.
nit: while here could you please remove white spaces: ": r=", as we have in other log messages (it is easier to grep for an error when it is uniform).
src/librbd/io/ReadResult.cc
Outdated
| AioCompletion *aio_completion, uint64_t object_off, uint64_t object_len, | ||
| Extents&& buffer_extents, bool ignore_enoent) | ||
| : aio_completion(aio_completion), object_off(object_off), | ||
| object_len(object_len),buffer_extents(std::move(buffer_extents)), |
There was a problem hiding this comment.
nit: needs a whitespace after the comma
src/librbd/LibrbdWriteback.cc
Outdated
| uint64_t _journal_tid, | ||
| const ZTracer::Trace &trace, Context *_req_comp) | ||
| : image_ctx(_image_ctx), oid(_oid), object_no(_object_no), off(_off), | ||
| bl(_bl), snapc(_snapc), journal_tid(_journal_tid), | ||
| trace(trace), req_comp(_req_comp) { | ||
| length(_bl.length()), bl(std::move(_bl)), snapc(_snapc), |
There was a problem hiding this comment.
nit: double whitespace after the comma
added 5 commits
February 26, 2018 12:28
This breaks the tight coupling between the IO work queue and the actual dispatch of IO requests. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
This will be used in a later cleanup to remove the IO flush handling from ImageCtx. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
dillaman
force-pushed
the
wip-22960-1
branch
from
dee3e6d
to
18bce0a
Compare
|
tweaks pushed |
trociny
approved these changes
Feb 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first part in a series that aims to remove the tied coupling of the object cacher from the IO pathway (to permit a plugable IO dispatcher).