osd/osd_types: kill preferred field in pg_t #20567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-kill-pg-preferred
branch
from
520f375
to
6d0ad8e
Compare
gregsfortytwo
approved these changes
Feb 23, 2018
src/osd/osd_types.h
Outdated
| @@ -438,15 +434,15 @@ struct pg_t { | |||
| encode(v, bl); | |||
| encode(m_pool, bl); | |||
| encode(m_seed, bl); | |||
| encode(m_preferred, bl); | |||
| encode((int32_t)-1, bl); | |||
There was a problem hiding this comment.
Please comment it here. How about
// previously held a pg preferred value
Or we could just have a named "int32_t reserved = -1;" sitting there.
We killed this many many years ago; remove it! Keep the hash<pg_t> value the same just in case this leaked into some on-disk or on-wire structure. Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-kill-pg-preferred
branch
from
6d0ad8e
to
df455a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was been unused (always -1) for many years.