ceph-objectstore-tool: don't destroy SnapMapper until the txn is completed #20593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise ceph-mgr will refuse to start if the required python binding, a.k.a mgr_module is not available in default sys.path. Signed-off-by: Kefu Chai <kchai@redhat.com>
|
this PR contains #20589 |
liewegas
approved these changes
Feb 26, 2018
…leted ch->flush() only ensure that the op is dequeued from osr/collection's queue. but the ops could be still in the flight and they could still be holding a *weak* reference of SnapMapper. we should make sure that the mapper is still available when they reference it, Fixes: http://tracker.ceph.com/issues/23121 Signed-off-by: Kefu Chai <kchai@redhat.com>
it never fails. Signed-off-by: Kefu Chai <kchai@redhat.com>
it never fails. Signed-off-by: Kefu Chai <kchai@redhat.com>
|
changelog
|
dzafman
reviewed
Feb 26, 2018
| @@ -415,6 +413,22 @@ int mark_pg_for_removal(ObjectStore *fs, spg_t pgid, ObjectStore::Transaction *t | |||
| #pragma GCC diagnostic pop | |||
| #pragma GCC diagnostic warning "-Wpragmas" | |||
|
|
|||
| template<typename Func> | |||
| void wait_until_done(ObjectStore::Transaction* txn, Func&& func) | |||
There was a problem hiding this comment.
Why is this mechanism needed now?
There was a problem hiding this comment.
see the commit message of 42f310f
dzafman
approved these changes
Feb 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and some cleanups