msg/async:fix the incoming parameter type of EventCenter::process_events() #20607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
reviewed
Feb 27, 2018
src/msg/async/Stack.cc
Outdated
| @@ -41,7 +41,7 @@ std::function<void ()> NetworkStack::add_thread(unsigned i) | |||
| char tp_name[16]; | |||
| sprintf(tp_name, "msgr-worker-%u", w->id); | |||
| ceph_pthread_setname(pthread_self(), tp_name); | |||
| const uint64_t EventMaxWaitUs = 30000000; | |||
| const int EventMaxWaitUs = 30000000; | |||
There was a problem hiding this comment.
instead, i think we should change EventCenter::process_events(int timeout_microseconds, ceph::timespan *working_dur) to EventCenter::process_events(unsigned timeout_microseconds, ceph::timespan *working_dur) . as the only reason we need an int timeout_microseconds is that std::chrono::microseconds::rep is a signed integer, but here, what we want is but a timeout, which will never be less than zero.
There was a problem hiding this comment.
that's ok, it would look better.
…) to EventCenter::process_events(unsigned timeout_microseconds) Signed-off-by: shangfufei <shangfufei@inspur.com>
shangfufei
force-pushed
the
test_stack
branch
from
70948e2
to
7705306
Compare
shangfufei
changed the title
shangfufei
changed the title
yuyuyu101
approved these changes
Feb 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the function of "EventCenter::process_events(int timeout_microseconds)",the type of incoming parameter is int, so change the type of EventMaxWaitUs from uint64_t to int.
Signed-off-by: shangfufei shangfufei@inspur.com