msg/async: avoid referencing the temporary string #20640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* get_val<std::string>(...) returns a temporary std::string, so we cannot keep a reference to it after evaluating this method. so convert it to an integer right away in the same expression. * use std::stoull() with base = 16, so we can parse a hex string representing up to 64 bits. Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-async-dpdk-temp-str
branch
from
ad29ac4
to
a2f65d7
Compare
|
@liu-chunmei in case you are interested. |
|
retest this please |
yuyuyu101
approved these changes
Mar 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_val<std::string>(...)returns a temporary std::string, so we cannotkeep a reference to it after evaluating this method. so convert it to
an integer right away in the same expression.
representing up to 64 bits.
Signed-off-by: Kefu Chai kchai@redhat.com