qa/run-standalone.sh: set PYTHONPATH for FreeBSD also #20646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
do not set PYTHONPATH=/usr/lib/python2.7/dist-packages anymore, it will be overridden later on anyway. Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
commented
Feb 28, 2018
| } | ||
|
|
||
| if [ `uname` = FreeBSD ]; then | ||
| # otherwise module prettytable will not be found | ||
| export PYTHONPATH=/usr/local/lib/python2.7/site-packages | ||
| export PYTHONPATH=$(get_python_path):/usr/local/lib/python2.7/site-packages |
There was a problem hiding this comment.
@wjwithagen FWIW, i am not trying to address the py3 support on FreeBSD, so i am leaving "python2.7" as it is.
There was a problem hiding this comment.
@tchaikov
Oke, that is fine. This could be some trouble in the (near) future when everything starts to do python3 as preferred. Fortunately this is only executed during manual runs and as such, mostly by devs. And we will fix it there if needed. Finding Prettytable during TOX was already separately fixed in a config.
Will need a working FreeBSD-jenkins before I can test this.
alfredodeza
approved these changes
Feb 28, 2018
|
@tchaikov This change is only a script run in the build tree. Doesn't require teuthology run. |
|
@dzafman i keep forgetting this. thanks for the reminder! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do not set PYTHONPATH=/usr/lib/python2.7/dist-packages anymore, it will
be overridden later on anyway.
Signed-off-by: Kefu Chai kchai@redhat.com