msg/async: execute on core specified by core_id not its index #20659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
force-pushed
the
wip-msg/async/dpdk/launch-on-coreid
branch
from
dafe3e8
to
6ae143b
Compare
otherwise the dpdk plugin does not compile. * remove workarounds for C++11. for example, std::void_t is available in C++17 now. * drop seastar::shared_ptr<>, as it's not used in async/dpdk now. * update the editor variable to match seastar's coding style Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
Reported-by: shangfufei <shangfufei@inspur.com> Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-msg/async/dpdk/launch-on-coreid
branch
from
6ae143b
to
494bf4b
Compare
yuyuyu101
reviewed
Mar 1, 2018
| if (i-- == 0) { | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
I think the idea of #20638 would be better
There was a problem hiding this comment.
@yuyuyu101 it's to get the core id from the its index. for example, if i is 0, the first non master core id is used.
There was a problem hiding this comment.
@shangfufei, i'd be happy to learn the rationale behind your assertion.
|
@yuyuyu101 ping? |
yuyuyu101
reviewed
Mar 6, 2018
| @@ -1,4 +1,4 @@ | |||
| // -*- mode:C++; tab-width:8; c-basic-offset:2; indent-tabs-mode:t -*- | |||
There was a problem hiding this comment.
just verify, is this update from seastar upstream file?
There was a problem hiding this comment.
no, it's not. see the commit message of d11a824 , none of the items listed in that commit message is from seastar upstream.
yuyuyu101
approved these changes
Mar 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported-by: shangfufei shangfufei@inspur.com
Signed-off-by: Kefu Chai kchai@redhat.com